After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654040 - [PATCH] Respect OnlyShowIn & NotShowIn for properties dialog
[PATCH] Respect OnlyShowIn & NotShowIn for properties dialog
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session-properties
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-05 19:05 UTC by Michael Terry
Modified: 2011-08-12 08:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.42 KB, patch)
2011-07-05 19:05 UTC, Michael Terry 		committed Details | Review

Description Michael Terry 2011-07-05 19:05:22 UTC 
Created attachment 191356 [details] [review]
Proposed patch

The properties dialog currently shows .desktop files for other desktops, which could confuse users, thinking they have something set to run on startup when they don't.

Here's a patch to look at OnlyShowIn (and TryExec too).

It uses the eggdesktopfile function for this to avoid duplicating code, but this means that GspApp now contains an EggDesktopFile object.  Which could be used much more widely in GspApp if we liked, to duplication even further.  But this patch here is more targeted, just caring about whether we can launch the app in question.
Comment 1 Vincent Untz 2011-08-12 08:32:46 UTC 
I reworked the patch to not use EggDesktopFile, it's in.