GNOME Bugzilla – Bug 653964
Installing MinGW32 build misses gdk/win32 headers
Last modified: 2011-08-16 06:28:59 UTC
Created attachment 191245 [details] [review] Patch against Makefile.am to install win32 headers Cross compiling GTK+ 3 on FC15 for the mingw32 environment misses headers which ought to be installed into gtk-3.0/gdk/win32. The header gtk-3.0/gdk/gdkwin32.h references these files, and it is impossible to build e.g. webkitgtk without them. Other GDK backends install files in e.g. gtk-3.0/gdk/x11 but the win32 headers are not included. I have submitted a patch to Fedora to fix this in their packaging. Attached is a patch to fix this here in the upstream location. Alternatively I have pushed my fix to http://dl.thehellings.com/gtk3.git
Review of attachment 191245 [details] [review]: The patch currently installs ALL the header files from win32/ directory, but we should only be installing the public ones. A good list of public headers to start with would be the ones referenced from gdkwin32.h: gdkwin32cursor.h gdkwin32display.h gdkwin32displaymanager.h gdkwin32dnd.h gdkwin32keys.h gdkwin32screen.h gdkwin32window.h Also, while you are at it, could you fix your email address in the git commit log to be something saner than <greg@Greg-PC.Belkin>?
Created attachment 193830 [details] [review] Patch with modifications requested I have pushed the requested git changes to http://dl.thehellings.com/gtk3.git in the branch gdk-headers and also included them in this patch. They include the modifications that Kalev requested.
Review of attachment 193830 [details] [review]: Looks good to me.
Review of attachment 193830 [details] [review]: Pushed to master as bd26ce1d.
Hi, Thanks for reporting this issue-the Visual Studio 2008/2010 property sheets has also been updated to copy the Win32-specific backend headers for GDK, as they were also missed there (pushed to gtk-3-0 as 9afbfdc5f40; pushed to master as e2397bf0da2ec06). God Bless!