GNOME Bugzilla – Bug 653741
[curl] New protocols in curlsink
Last modified: 2012-05-12 11:06:30 UTC
Created attachment 191011 [details] curlbasesink - base class Added support for FILE, FTP and secure FTP protocols to curlsink plugin.
Created attachment 191012 [details] curlbasesink - header file
Created attachment 191013 [details] curlfilesink
Created attachment 191014 [details] curlfilesink - header file
Created attachment 191015 [details] curlftpsink
Created attachment 191016 [details] curlftpsink - header file
Created attachment 191017 [details] curlhttpsink
Created attachment 191018 [details] curlhttpsink - header file
Created attachment 191019 [details] curltlssink
Created attachment 191020 [details] curltlssink - header file
Created attachment 191021 [details] check test
Created attachment 191023 [details] check test
Please attach patches, preferably made with 'git format-patch', instead of individual source files. There is no need for separate elements to handle other URL methods like ftp: and file:. This functionality can go in curlsink, if it's not already there.
Patricia, can you please incorporate changes as requested in comment#12 ?
Sorry for my delayed answer. Those files I attached a while ago, are totally rewritten and do not exist in the repository. I've chosen to split protocols into separate files because in my opinion the design is much cleaner. I'm currently working on SMTP-curlsink addition and just by extending the current version of curlsink with this protocol makes the code look more “clumsy”. Maybe in the future somebody wants to extend curlsink with all the protocols supported by libcurl or just to add new properties to the currently supported protocols. Keeping the current design will unnecessary complicate this approach.
Created attachment 202470 [details] curlsmtpsink
Created attachment 202471 [details] curlsmtpsink - header file
Hello again, I've attached SMTP-curlsink files. Thank you!
Hello, What the status of this Bug? I've more updates/fixes and a new ftp-ssh implementation ongoing. Thank you!
Created attachment 205861 [details] [review] curlhttpsink
Created attachment 205862 [details] [review] curlfilesink
Created attachment 205863 [details] [review] curlftpsink
Created attachment 205864 [details] [review] curlsmtpsink
Hello, I've attached patches made with 'git format-patch'.
Could you please to have a look at my patches? We have more bug fixes ongoing. Thank you!
Created attachment 210349 [details] [review] curlhttpsink
Created attachment 210350 [details] [review] curlfilesink
Created attachment 210351 [details] [review] curlftpsink
Created attachment 210352 [details] [review] curlsmtpsink
Created attachment 212881 [details] [review] Patch for curlhttpsink (ported to 0.11).
Created attachment 212882 [details] [review] Patch for curlfilesink (ported to 0.11).
Created attachment 212883 [details] [review] Patch for curlftpsink (ported to 0.11).
Created attachment 212884 [details] [review] Patch for curlsmtpsink (ported to 0.11).
Created attachment 212895 [details] [review] Patch for curlsmtpsink (ported to 0.11).
Thanks, I've pushed these to master now. Haven't reviewed in depth, but looks fine at first glance, don't see any reason not to just push these. I would like to see the FIXMEs around the properties fixed (sync property names with souphttpsrc), if still relevant. What is the purpose of curlfilesink? What can it do that filesink can't do? Why have it? I'd rather see options like the create-directories added to filesink. Why are there separate properties for the file-name and the directory (location)? I noticed the property description refers to 'for the uploaded images', but not quite sure what it means / how it works. Can't we stuff that all into location as it's done for other things (even e.g. splitfilesrc)? commit 3f20bbdcf4b437bf63a7426a5deac45a3c8267d7 Author: Sebastian Rasmussen <sebrn@axis.com> Date: Wed Apr 25 19:46:53 2012 +0200 curl: new curlsmtpsink element https://bugzilla.gnome.org/show_bug.cgi?id=653741 commit 766dd8bb717b1ba5317fbd2c5d7860d6beb34834 Author: Patricia Muscalu <patricia@axis.com> Date: Mon Jan 23 09:45:24 2012 +0100 curl: new curlftpsink element http://bugzilla.gnome.org/show_bug.cgi?id=653741 commit f139656becf17dce39be0fe180796794aa3b8875 Author: Patricia Muscalu <patricia@axis.com> Date: Mon Jan 23 09:28:10 2012 +0100 curl: new curlfilesink element https://bugzilla.gnome.org/show_bug.cgi?id=653741 commit ae39cbfa577adf48f50f11b67121670275480d92 Author: Patricia Muscalu <patricia@axis.com> Date: Mon Jan 23 09:00:47 2012 +0100 curl: refactor curlsink, rename to curlhttpsink Split into base, tls and http classes. https://bugzilla.gnome.org/show_bug.cgi?id=653741