After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653700 - Run (alt+F2) dialog breaks locks system modality when read errors occur
Run (alt+F2) dialog breaks locks system modality when read errors occur
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.0.x
Other Linux
: Normal major
: ---
Assigned To: Florian Müllner
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-30 02:35 UTC by Jean-François Fortin Tam
Modified: 2011-07-20 00:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
runDialog: catch exceptions from Gio.app_info_launch_default_for_uri() (3.88 KB, patch)
2011-07-06 19:49 UTC, Rui Matos 		committed Details | Review

Description Jean-François Fortin Tam 2011-06-30 02:35:56 UTC 
To reproduce on fedora:
- alt+F2
- type "/etc/grub.conf"
- press Enter

Result: nothing happens (I think that there is a permission reading error when you try to open that file), yet you are stuck with the "alt+F2 dialog" that prevents you from using any other part of the shell and just won't go away until you kill X with ctrl+alt+backspace.
Comment 1 Rui Matos 2011-07-06 19:49:09 UTC 
Created attachment 191421 [details] [review]
runDialog: catch exceptions from Gio.app_info_launch_default_for_uri()

An uncaught exception here would mean that the dialog wouldn't close.
Comment 2 Florian Müllner 2011-07-12 16:51:10 UTC 
Review of attachment 191421 [details] [review]:

A minor suggestion regarding the regex, otherwise looks good.

::: js/ui/runDialog.js
@@ +342,3 @@
+                        //     is registered as handling this file
+                        // We are only interested in the part after the colon.
+                        let message = e.message.replace(/.*: *(.+)/, '$1');

A corner case, but we should use the part after the _first_ colon, in case the the message itself contains a colon too:

/[^:]*: *(.+)/
Comment 3 Florian Müllner 2011-07-20 00:03:19 UTC 
Attachment 191421 [details] pushed as d12dd14 - runDialog: catch exceptions from Gio.app_info_launch_default_for_uri()