After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653648 - [ffmpegdec] allocates and leaks avpacket helper structs
[ffmpegdec] allocates and leaks avpacket helper structs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal blocker
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-29 14:27 UTC by Mark Nauwelaerts
Modified: 2011-06-30 09:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ffmpeg: avoid allocating and leaking local avpacket helper (2.65 KB, patch)
2011-06-29 14:27 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2011-06-29 14:27:56 UTC 
Created attachment 190935 [details] [review]
ffmpeg: avoid allocating and leaking local avpacket helper

Subject says all, note that one such struct is leaked for every input frame/buffer.

Attached patch uses some _init to setup an instance on stack, rather than allocating (and then leaking) one with some _new.  Not sure what (if any) the particular reason was for going down the _new route to start with.
Comment 1 Mark Nauwelaerts 2011-06-30 09:53:25 UTC 
commit 856dbe6f2150cea571640c841140d395e9e34890
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Jun 29 16:22:48 2011 +0200

    ffmpegdec: avoid allocating and leaking local avpacket helpers
    
    ... by _init'ing them as locals rather than _new'ing them.
    
    Fixes #653648.