Created attachment 190923 [details] [review]
Patch to add preference for 'finger' instead of 'pinky' in gnome-nettool

Currently, gnome-nettool will use 'pinky' even if 'finger' exists on a system.

The code for selecting a finger client is as follows:

  program = util_find_program_in_path ("pinky", NULL);

  if (program != NULL) {
    program_name = g_strdup ("pinky");
  } else {
    program = util_find_program_dialog ("finger", parent);
    program_name = g_strdup ("finger");
  }

This is a problem because:

* pinky is by definition a light-weight replacement for finger that does not actually use the finger network protocol -- it only examines the local utmp file.
* Even if both full-featured finger and pinky are installed, gnome-nettool still uses pinky.
* Many non-Linux systems (like *BSD) have proper finger programs and it is odd that gnome-nettool prefers a non-standard client.

The code should first attempt to find a finger program and fall back to pinky if it exists -- not the other way around.