GNOME Bugzilla – Bug 653559
aacparse: too greedy minimum frame size
Last modified: 2011-06-28 10:44:56 UTC
Same motivation as for this commit: http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=d17d6d74beeb8c4fd4c804d1f0b1951f3bdd06ff "... which will be determined by parsing anyway, and avoids introducing redundant additional latency" For low bitrate streams with initial silence the current minimum size 1024 can represent lots of frames. Mainly a problem together with video.
Created attachment 190842 [details] [review] Change minimum frame size to ADTS_MAX_SIZE
This should already have been tweaked by following commit: commit d17d6d74beeb8c4fd4c804d1f0b1951f3bdd06ff Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> Date: Mon Jun 13 17:05:19 2011 +0200 audioparsers: not so greedy minimum frame size ... which will be determined by parsing anyway, and avoids introducing redundant additional latency.
I fail to see how that commit affects aacparse. It does fix ac3parse and mpegaudioparse though. 2 files changed, 7 insertions, 2 deletions -rw-r--r-- gst/audioparsers/gstac3parse.c -rw-r--r-- gst/audioparsers/gstmpegaudioparse.c
Oops, misread that part, have been playing around with too many parsers, so it all tends to blur a bit ;)
commit 1912c869469bec10dddcd26a82d18ef767228a1d Author: Jonas Larsson <jonas.larsson@hiq.se> Date: Tue Jun 28 12:26:37 2011 +0200 aacparse: not so greedy minimum frame size Fixes #653559.