After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653549 - Need for a "media-constructed" signal from GstRTSPMediaFactory
Need for a "media-constructed" signal from GstRTSPMediaFactory
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
unspecified
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-28 08:30 UTC by Emmanuel Pacaud
Modified: 2018-06-29 22:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (3.13 KB, patch)
2011-06-28 08:30 UTC, Emmanuel Pacaud 		none Details | Review
patch made using git-format-patch (3.72 KB, patch)
2011-06-30 08:23 UTC, Emmanuel Pacaud 		none Details | Review

Description Emmanuel Pacaud 2011-06-28 08:30:16 UTC 
Created attachment 190831 [details] [review]
patch

I'm building a rtsp server application in which I'm using appsrc elements in the stream pipeline.

I didn't find an easy way to retrieve a pointer to the appsrc elements after their creation.

The attached patch implements a "media-constructed" signal which gives me the newly constructed GstRTSPMedia and its pipeline.
Comment 1 David Schleef 2011-06-30 05:02:20 UTC 
Seems reasonable.  You can also override the get_element method and do what you need to there.  However, having a specific signal is probably more discoverable.

Could you start attaching patches created using 'git format-patch'?  Patches in that form are much easier to apply.

(Also.  Dude.  No structure padding.  wtf.  I doubt it matters, since it is unlikely anyone is subclassing GstRTSPMediaFactory.)
Comment 2 Emmanuel Pacaud 2011-06-30 08:23:13 UTC 
Created attachment 190995 [details] [review]
patch made using git-format-patch
Comment 3 Emmanuel Pacaud 2011-06-30 08:25:17 UTC 
> (Also.  Dude.  No structure padding.  wtf. I doubt it matters, since it is
unlikely anyone is subclassing GstRTSPMediaFactory.)

I don't understand this comment. Which padding ?
Comment 4 Emmanuel Pacaud 2011-08-03 14:18:47 UTC 
Will this patch be applied as is, or does it need some more work ?
Comment 5 Wim Taymans 2011-08-16 09:56:39 UTC 
committed Thanks!

commit 5dc9e76125466be7990187b78000b1df32704312
Author: Emmanuel Pacaud <emmanuel@gnome.org>
Date:   Thu Jun 30 10:13:59 2011 +0200

    media-factory: add a "media-constructed" signal to GstRTSPMediaFactory
    
    For example, it can be used to retrieve source elements like appsrc, in a more
    convenient way than subclassing get_element.