After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653436 - Improve 2.0/4.0 profile detection
Improve 2.0/4.0 profile detection
Status: RESOLVED FIXED
Product: longomatch
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: 0.16
Assigned To: Andoni Morales
longomatch-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-26 17:40 UTC by Iain Lane
Modified: 2011-07-10 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow manually set compiler to use 2.0 or 4.0 profile (1.33 KB, patch)
2011-06-26 17:40 UTC, Iain Lane
none Details | Review

Description Iain Lane 2011-06-26 17:40:16 UTC
Created attachment 190703 [details] [review]
Allow manually set compiler to use 2.0 or 4.0 profile

Hi there,

Currently in git, if the user overrides MCS then the build system
unconditionally checks for 4.0 libraries (using
SHAMROCK_CHECK_MONO_4_0_GAC_ASSEMBLIES). It'd be better if this variable didn't
influence the profile to check against. To that end, I've cooked up a patch
which does this. MCS overriding has no effect on the GAC assembly checking now
— the version to check for is inferred from the installed mono version.

The reason I want this is because, in Debian, we have a symlink
/usr/bin/mono-csc which points to our system default. We ask packages to use
this compiler to build. It points to gmcs on 2.6.7 (which is in unstable
currently), and dmcs on 2.10 (in experimental and oneiric). Without this patch,
because longomatch assumes 4.0 if MCS is changed, I cannot build against
unstable's default compiler.

Attached. Let me know what you think. I'm going to upload it to unstable now as
part of a git snapshot which includes 4.0 support (thanks for implementing
this).

Cheers,
Iain
Comment 1 Andoni Morales 2011-07-10 14:38:10 UTC
Pushed, thanks!


commit 6f2e71cd7801a42d29cb7c11dc050ce198246d13
Author: Iain Lane <laney@debian.org>
Date:   Sun Jun 26 18:04:10 2011 +0100

    Allow manually set compiler to support 2.0 or 4.0
    
    Previously the 4.0 profile was forced when MCS was explicitly set.
    Instead infer the profile to use from the system.