After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653429 - drop AM_MAINTAINER_MODE or enable it by default
drop AM_MAINTAINER_MODE or enable it by default
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-06-26 14:31 UTC by Allison Karlitskaya (desrt)
Modified: 2011-06-27 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Allison Karlitskaya (desrt) 2011-06-26 14:31:23 UTC 
Currently, doing an ./autogen.sh of GLib results in Makefiles that don't rebuild themselves on changes.  That's quite annoying.

It's caused by our use of AM_MAINTAINER_MODE, which disables those rules unless --enable-maintainer-mode is given to ./configure.

We used to give that to ./configure from autogen.sh, but Javier removed that with commit d2d3449a8ef4e3ad7236ed83a5ed0ce6a2b0e69f on May 16.

Short of adding it back (which I do not favour), there are two fixes:

  - remove AM_MAINTAINER_MODE so that the rules are always enabled

  - use AM_MAINTAINER_MODE([enable]) so that we get it unless
    --disable-maintainer-mode is explicitly given

--disable-maintainer-mode makes absolutely no sense to me, but apparently some vendors like it because it allows them to patch things and suppress the rebuilds that would otherwise occur.  It might be worth keeping it for that reason.
Comment 1 Javier Jardón (IRC: jjardon) 2011-06-26 15:07:18 UTC 
After some discussion, seems that the preferred option is to use the macro but enabled by default:

AM_MAINTAINER_MODE([enable])

See https://live.gnome.org/GnomeGoals/ModernAutotools
Comment 2 Allison Karlitskaya (desrt) 2011-06-27 13:19:34 UTC 
commit b07f2833c0d2ab8282fae0c19ef065a38721a985
Author: Ryan Lortie <desrt@desrt.ca>
Date:   Mon Jun 27 11:28:55 2011 +0100

    Change to AM_MAINTAINER_MODE([enable])
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=653429