After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653206 - Minor enhancements to the extension-tool.
Minor enhancements to the extension-tool.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-23 02:36 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-07-13 19:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
extension-tool: Use socket.gethostname() instead of an external process (1.12 KB, patch)
2011-06-23 02:36 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
extension-tool: Clean up code creator, update sample (4.26 KB, patch)
2011-06-23 02:36 UTC, Jasper St. Pierre (not reading bugmail)
accepted-commit_now Details | Review
extension-tool: Clean up code creator, update sample (4.26 KB, patch)
2011-07-13 18:37 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-06-23 02:36:31 UTC
Just some minor code maintenance to the tool.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-06-23 02:36:33 UTC
Created attachment 190485 [details] [review]
extension-tool: Use socket.gethostname() instead of an external process

Minor code cleanup.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-06-23 02:36:36 UTC
Created attachment 190486 [details] [review]
extension-tool: Clean up code creator, update sample

Update the sample to be more up to date with respect to Shell practices,
and make it look a bit prettier. Additionally, change the file extract
code so that it's easier to update and add new files later.
Comment 3 drago01 2011-07-13 18:08:32 UTC
Review of attachment 190485 [details] [review]:

Looks much better.
Comment 4 drago01 2011-07-13 18:11:24 UTC
Review of attachment 190486 [details] [review]:

Looks good, fine to commit with a that simple api fix.

::: src/gnome-shell-extension-tool.in
@@ +49,3 @@
+    text.opacity = 255;
+
+    let monitor = global.get_primary_monitor();

Should be Main.layoutManager.primaryMonitor
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-07-13 18:37:07 UTC
Created attachment 191912 [details] [review]
extension-tool: Clean up code creator, update sample

Update the sample to be more up to date with respect to Shell practices,
and make it look a bit prettier. Additionally, change the file extract
code so that it's easier to update and add new files later.
Comment 6 Jasper St. Pierre (not reading bugmail) 2011-07-13 19:04:08 UTC
Attachment 190485 [details] pushed as c8d5e0a - extension-tool: Use socket.gethostname() instead of an external process
Attachment 191912 [details] pushed as 7a8a00c - extension-tool: Clean up code creator, update sample