After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653095 - Behaviour whilst opening settings dialog in overview
Behaviour whilst opening settings dialog in overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-21 10:54 UTC by Simon Booth
Modified: 2011-06-23 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Exit the overview when launching control center (1.86 KB, patch)
2011-06-21 22:27 UTC, Colin Walters 		needs-work Details | Review
Consistently exit the overview when launching external applications (4.77 KB, patch)
2011-06-22 21:34 UTC, Colin Walters 		committed Details | Review

Description Simon Booth 2011-06-21 10:54:55 UTC 
If you are in the activites overview and you select one of the settings from the top bar (accessibility, Date and Time etc), the settings dialog is opened and placed in the overview rather than brought to the foreground.

This seems contrary to all other application launches from the overview (either the dash or the applications picker) where the overview is closed and the application started in the foreground.
Comment 1 Colin Walters 2011-06-21 22:27:17 UTC 
Created attachment 190395 [details] [review]
Exit the overview when launching control center
Comment 2 Florian Müllner 2011-06-22 21:23:31 UTC 
Review of attachment 190395 [details] [review]:

Missing import in a11y; other than that - what about keyboard, sound, bluetooth, power?

::: js/ui/status/accessibility.js
@@ +89,3 @@
         this.menu.addMenuItem(new PopupMenu.PopupSeparatorMenuItem());
         this.menu.addAction(_("Universal Access Settings"), function() {
+            Main.overview.hide();

Main is undefined.
Comment 3 Colin Walters 2011-06-22 21:34:41 UTC 
Created attachment 190474 [details] [review]
Consistently exit the overview when launching external applications

Fix for review comments
Comment 4 Florian Müllner 2011-06-22 21:40:48 UTC 
Review of attachment 190474 [details] [review]:

Good to commit after adding bluetooth ;-)
Comment 5 Colin Walters 2011-06-23 16:46:32 UTC 
Attachment 190474 [details] pushed as 8834a7d - Consistently exit the overview when launching external applications