Created attachment 192108 [details] [review]
Use Region & Language Settings label

This patch also removes the unneeded ellipsis from "Show Keyboard Layout"

Review of attachment 192108 [details] [review]:

Seems fine (might cause the menu to get wider for verbose languages, not much we can do about that) Localization is definitely an obscure word that shouldn't be in our menus.

(In reply to comment #1)
> This patch also removes the unneeded ellipsis from "Show Keyboard Layout"

I'm not sure about that change - it seems consistent with other "actions which open a dialog" (e.g. user->logout, bluetooth->send files, ...)

Florian, the HIG states:

"Use an ellipsis (...) at the end of the label if the action requires further input from the user before it can be carried out. For example, Save As... or Find.... Do not add an ellipsis to commands like Properties, Preferences, or Settings, as these open windows that do not require further input."

http://developer.gnome.org/hig-book/unstable/controls-buttons.html.en

By the way, Canonical's mpt doesn't like that guideline and Unity uses "Settings..." for their indicator status menus. He complains about it in bug 169447.

I don't have a strong opinion on the ellipsis, the comment was meant more as "please check with the designers before committing", as the corresponding mockup uses them ...

While we are vacillating about ellipses, I think that 'More...' in the network menu really doesn't need them.

Hi, I'm just pinging this bug report again before the string/UI announcement period starts tonight.

When I mentioned this bug on #gnome-design, the response was that if "Show Keyboard Layout" gets the ellipsis, then the Region & Language Settings probably should too. I suspect the menus would be overrun with ellipses soon after.