After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652812 - Don't create dummy extradata for AAC LATM
Don't create dummy extradata for AAC LATM
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other All
: Normal blocker
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-17 11:05 UTC by Raimo Järvi
Modified: 2011-07-18 10:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't create dummy extradata for AAC LATM (1.05 KB, patch)
2011-06-17 11:09 UTC, Raimo Järvi 		committed Details | Review

Description Raimo Järvi 2011-06-17 11:05:23 UTC 
Creating dummy extradata in gst_ffmpeg_caps_with_codecid causes problems for AAC LATM decoding, because libav will use the dummy data for initialising the AAC decoder (see libavcodec/aacdec.c) and this breaks LATM decoding.

The following patch should fix this.
Comment 1 Raimo Järvi 2011-06-17 11:09:11 UTC 
Created attachment 190104 [details] [review]
Don't create dummy extradata for AAC LATM
Comment 2 Sebastian Dröge (slomo) 2011-06-26 12:25:12 UTC 
Will the decoder work if no codec_data is provided at all? Would it be possible to construct valid codec_data from the caps?
Comment 3 Raimo Järvi 2011-06-26 15:07:33 UTC 
Yes, it will work, libav LATM parser and decoder will parse the necessary information from the LATM stream. AFAIK there is no LATM parser in GStreamer, so I don't see how we could construct codec_data.
Comment 4 Sebastian Dröge (slomo) 2011-06-26 15:18:28 UTC 
Ok, for that see bug #615740 and your patch is correct :)
Comment 5 Edward Hervey 2011-07-18 10:05:52 UTC 
commit 95fe6ca01e7a1bb7b889b794dd4f64fedcf26139
Author: Raimo Järvi <raimo.jarvi@gmail.com>
Date:   Fri Jun 17 14:05:58 2011 +0300

    codecmap: Don't create dummy extradata for AAC LATM
    
    If extradata is created for LATM, libav will use it for initialising AAC
    decoder and decoding will fail.
    
    Fixes bug #652812.