After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652532 - Delay time is invalid on burst mode
Delay time is invalid on burst mode
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
3.0.x
Other Linux
: Normal normal
: 2.32
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-06-14 08:38 UTC by Max Lin
Modified: 2011-09-08 16:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix delay time is invalid on burst mode (1.27 KB, patch)
2011-06-14 10:56 UTC, Max Lin 		none Details | Review
simplified patch to fix burst mode delay time (1.29 KB, patch)
2011-09-07 15:04 UTC, David King 		committed Details | Review

Description Max Lin 2011-06-14 08:38:05 UTC 
Launch cheese and set delay 6 seconds between photos, starting with burst mode, after 6 second then cheese didn't take photo, but cheese capturing after about 20 seconds(contain countdown animation).

Reproduce Steps:
1. Launch cheese 3.0.1 on openSUSE 11.4
2. Edit->Preferences->set "Delay Between Photos" entry as 6 seconds
3. Switch to burst mode
4. Clicked "Take Multiple Photos" button
5. Watch the issue appear after 6 seconds


Actual Results:  
Not take next photo after 6 seconds

Expected Results:
Capturing after 6 seconds
Comment 1 Max Lin 2011-06-14 10:56:57 UTC 
Created attachment 189889 [details] [review]
fix delay time is invalid on burst mode

I found a weird way to calculated delay time, the line at 794 in cheese-window.vala:

burst_callback_id = GLib.Timeout.add ((settings.get_int ("burst-delay") / 1000) * 3500, burst_take_photo);

I don't understanding why need multiply by 3500. I made a patch, if burst-delay time less than 3500 ms, and countdown entry is checked, the delay time as 3500 ms(for countdown animation could finish), otherwise used burst-delay time what we set on Preference dialog. 

The patch works fine in my machine. I am not sure this patch consistent with default behavior, but it's meet the behavior what I think in my head :-)
Comment 2 David King 2011-09-07 15:04:58 UTC 
Created attachment 195882 [details] [review]
simplified patch to fix burst mode delay time

I simplified your patch slightly, and attached the newer version. It looks good, and is a straightforward fix.
Comment 3 David King 2011-09-08 16:07:28 UTC 
Comment on attachment 195882 [details] [review]
simplified patch to fix burst mode delay time

I pushed this to master as commit 1baf1919d4a21aba125343d916f99eae3cce4974, thanks.