After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652472 - Handle failure in getting the logger service better
Handle failure in getting the logger service better
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Telepathy backend
git master
Other All
: Normal minor
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-13 16:20 UTC by Philip Withnall
Modified: 2011-06-23 16:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Handle failure in getting the logger off the bus better (1.37 KB, patch)
2011-06-13 16:22 UTC, Philip Withnall 		accepted-commit_now Details | Review

Description Philip Withnall 2011-06-13 16:20:12 UTC 
We don't check that the logger was successfully proxied from the bus. Branch coming up.
Comment 1 Philip Withnall 2011-06-13 16:22:52 UTC 
Created attachment 189834 [details] [review]
Handle failure in getting the logger off the bus better

http://cgit.collabora.com/git/user/pwith/folks/log/?h=652472-logger-failure
Comment 2 Travis Reitter 2011-06-23 16:07:10 UTC 
Review of attachment 189834 [details] [review]:

Looks good - please merge.
Comment 3 Travis Reitter 2011-06-23 16:08:13 UTC 
(In reply to comment #2)
> Review of attachment 189834 [details] [review]:
> 
> Looks good - please merge.

Actually, please make sure you update NEWS as well.
Comment 4 Travis Reitter 2011-06-23 16:35:29 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Review of attachment 189834 [details] [review] [details]:
> > 
> > Looks good - please merge.
> 
> Actually, please make sure you update NEWS as well.

Fixed (including the NEWS):

commit 2d042c289bcc140f402c20603c12e57339815cf4
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Mon Jun 13 17:20:34 2011 +0100

    Bug 652472 — Handle failure in getting the logger service better
    
    If we fail to get the logger from the bus, get_object() may return NULL. If
    we check for this, we don't then try and connect a signal to a NULL object
    instance and emit criticals.
    
    Closes: bgo#652472

 NEWS                                   |    1 +
 backends/telepathy/lib/tpf-logger.vala |    7 +++++++
 2 files changed, 8 insertions(+), 0 deletions(-)