After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652388 - shell-window-tracker: Fix signal handler leak
shell-window-tracker: Fix signal handler leak
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-12 12:05 UTC by drago01
Modified: 2011-06-13 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-window-tracker: Fix signal handler leak (1.01 KB, patch)
2011-06-12 12:05 UTC, drago01 		committed Details | Review

Description drago01 2011-06-12 12:05:19 UTC 
See patch.
Comment 1 drago01 2011-06-12 12:05:23 UTC 
Created attachment 189759 [details] [review]
shell-window-tracker: Fix signal handler leak

Disconnect the on_wm_class_changed handler when removing a window
in disassociate_window().
Comment 2 Owen Taylor 2011-06-13 14:09:52 UTC 
Review of attachment 189759 [details] [review]:

The code looks as correct as the current code. I'm really not liking the fact that the current code counts on the fact that shell_window_tracker_is_window_interesting() doesn't change, while it *can* change - skip_taskbar and the window type can be changed on the fly by Mutter. But that's a separate bug that was introduced by commit 4b1fea2f (which probably should be solved by tracking changes to is_window_interesting rather than by correcting the accounting logic.) So this should be OK to commit.
Comment 3 drago01 2011-06-13 15:03:33 UTC 
Attachment 189759 [details] pushed as 1309b64 - shell-window-tracker: Fix signal handler leak