After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652304 - themingengine: don't hardcode the slider lines in the theming engine
themingengine: don't hardcode the slider lines in the theming engine
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-06-10 17:46 UTC by Cosimo Cecchi
Modified: 2012-05-04 21:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
themingengine: don't hardcode the slider lines in the theming engine (1.94 KB, patch)
2011-06-10 17:46 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-06-10 17:46:55 UTC 
GtkThemingEngine hardcodes the slider lines in its _render_slider() implementation, which forces theme to override the method if they want to get rid of them.
Comment 1 Cosimo Cecchi 2011-06-10 17:46:57 UTC 
Created attachment 189656 [details] [review]
themingengine: don't hardcode the slider lines in the theming engine

It's wrong to hardcode the slider lines here; those should be rendered
as an additional background layer using background-image if the theme
specifies so.
Comment 2 Cosimo Cecchi 2012-05-04 21:27:28 UTC 
Attachment 189656 [details] pushed as e5f0e30 - themingengine: don't hardcode the slider lines in the theming engine