After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652286 - matroskaparse: Gstreamer-CRITICAL when changing state from PAUSED to READY
matroskaparse: Gstreamer-CRITICAL when changing state from PAUSED to READY
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-10 13:22 UTC by Debarshi Ray
Modified: 2011-06-30 07:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (1.60 KB, patch)
2011-06-10 13:26 UTC, Debarshi Ray 		none Details | Review

Description Debarshi Ray 2011-06-10 13:22:40 UTC 
In gst_matroska_parse_output, we can not use parse->streamheader after calling gst_buffer_make_metadata_writable.

Also it might be a good idea to use gst_buffer_copy while putting parse->streamheader into a GValue, earlier in the same function. Other elements are doing something similar as well, and Tim thinks it is better than relying on GST_BUFFER_FLAG_IN_CAPS.
Comment 1 Debarshi Ray 2011-06-10 13:26:04 UTC 
Created attachment 189626 [details] [review]
Proposed fix
Comment 2 David Schleef 2011-06-30 07:05:06 UTC 
commit c8619aa0fdc114e9bae0f88f76aa093f96d066b3
Author: Debarshi Ray <rishi@gnu.org>
Date:   Fri Jun 10 18:54:48 2011 +0530

    matroskaparse: fix reference counting of parse->streamheader
    
    https://bugzilla.gnome.org/show_bug.cgi?id=652286
    
    Signed-off-by: David Schleef <ds@schleef.org>