After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652010 - fix exit status
fix exit status
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-06 20:22 UTC by Dan Winship
Modified: 2011-06-06 21:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meta_quit: ignore repeated calls after it's already quitting (1.06 KB, patch)
2011-06-06 20:22 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-06-06 20:22:29 UTC 
The meta_finalize() changes had the unintended side effect of causing
gnome-shell to always exit with status 0, which meant that debugexit'ing
left you with no wm rather than starting metacity+gnome-panel.

(The fact that meta_display_close() calls meta_quit() is a little weird,
but fixing meta_quit() to be idempotent seems right anyway.)
Comment 1 Dan Winship 2011-06-06 20:22:31 UTC 
Created attachment 189361 [details] [review]
meta_quit: ignore repeated calls after it's already quitting

meta_run() calls meta_finalize() after the main loop exits, which ends
up calling meta_display_close(), which calls
meta_quit(META_EXIT_SUCCESS), meaning that any exit status passed to
the original meta_quit() call is lost.

Fix this by ignoring meta_quit() calls after the main loop is no
longer running.
Comment 2 Colin Walters 2011-06-06 20:28:12 UTC 
Review of attachment 189361 [details] [review]:

Looks safe.
Comment 3 Dan Winship 2011-06-06 21:27:15 UTC 
Attachment 189361 [details] pushed as c70087d - meta_quit: ignore repeated calls after it's already quitting