After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652005 - Use "const" instead G_CONST_RETURN
Use "const" instead G_CONST_RETURN
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 644611
 
 
Reported: 2011-06-06 18:17 UTC by Javier Jardón (IRC: jjardon)
Modified: 2011-06-10 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gail: do not use G_CONST_RETURN (38.50 KB, patch)
2011-06-06 18:17 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gail/test: Do not use G_CONST_RETURN (17.10 KB, patch)
2011-06-06 18:18 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gdk: Do not use G_CONST_RETURN (9.35 KB, patch)
2011-06-06 18:19 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
docs: Do not use G_CONST_RETURN (1.99 KB, patch)
2011-06-06 18:19 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
gtk: Do not use G_CONST_RETURN (87.29 KB, patch)
2011-06-06 18:20 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2011-06-06 18:17:00 UTC 
Before deprecate the macro in Glib. See bug #644611
Comment 1 Javier Jardón (IRC: jjardon) 2011-06-06 18:17:50 UTC 
Created attachment 189346 [details] [review]
gail: do not use G_CONST_RETURN
Comment 2 Javier Jardón (IRC: jjardon) 2011-06-06 18:18:30 UTC 
Created attachment 189347 [details] [review]
gail/test: Do not use G_CONST_RETURN
Comment 3 Javier Jardón (IRC: jjardon) 2011-06-06 18:19:10 UTC 
Created attachment 189348 [details] [review]
gdk: Do not use G_CONST_RETURN
Comment 4 Javier Jardón (IRC: jjardon) 2011-06-06 18:19:50 UTC 
Created attachment 189349 [details] [review]
docs: Do not use G_CONST_RETURN
Comment 5 Javier Jardón (IRC: jjardon) 2011-06-06 18:20:33 UTC 
Created attachment 189350 [details] [review]
gtk: Do not use G_CONST_RETURN
Comment 6 Matthias Clasen 2011-06-06 18:33:57 UTC 
Review of attachment 189346 [details] [review]:

G_CONST_RETURN certainly makes no sense whatsoever for static functions that are private to the implmentation. Go ahead.
Comment 7 Matthias Clasen 2011-06-06 18:35:10 UTC 
Review of attachment 189347 [details] [review]:

Go ahead.
Comment 8 Matthias Clasen 2011-06-06 18:39:04 UTC 
Review of attachment 189348 [details] [review]:

The changes to all the static functions are obviously ok. For the public API, we should just decide whether we drop this thing or now. 
-> topic for the next meeting.
Comment 9 Matthias Clasen 2011-06-06 18:40:41 UTC 
Review of attachment 189349 [details] [review]:

Also, pending on a decision to drop this from the api
Comment 10 Javier Jardón (IRC: jjardon) 2011-06-07 13:31:18 UTC 
Comment on attachment 189346 [details] [review]
gail: do not use G_CONST_RETURN

commit 5e2b5680a491da87cb8f22ca90df09248f3884e6
Comment 11 Javier Jardón (IRC: jjardon) 2011-06-07 13:31:40 UTC 
Comment on attachment 189347 [details] [review]
gail/test: Do not use G_CONST_RETURN

commit 15a914202d4fd3858e862dbc7a1e01a72bc7891c
Comment 12 Matthias Clasen 2011-06-10 03:08:07 UTC 
I have been convinced to just go ahead with this.
Comment 13 Javier Jardón (IRC: jjardon) 2011-06-10 12:13:24 UTC 
Comment on attachment 189348 [details] [review]
gdk: Do not use G_CONST_RETURN

commit 7c688cb8a6cd35990a26d3a4a26d098e3a5fe5a1
Comment 14 Javier Jardón (IRC: jjardon) 2011-06-10 12:13:41 UTC 
Comment on attachment 189349 [details] [review]
docs: Do not use G_CONST_RETURN

commit a8f5a8b9190d4c72f46a38579f23f2f2acfb174a
Comment 15 Javier Jardón (IRC: jjardon) 2011-06-10 12:13:59 UTC 
Comment on attachment 189350 [details] [review]
gtk: Do not use G_CONST_RETURN

commit bf0d8402f5382fadd32a9748d00a4bcd715ea07a
Comment 16 Javier Jardón (IRC: jjardon) 2011-06-10 12:14:38 UTC 
Thanks Matthias