GNOME Bugzilla – Bug 651842
Dash icon dragging placeholder jumps around
Last modified: 2012-03-13 23:10:08 UTC
1. Grab a dash icon 2. Move down until you see the drop target placeholder appear. 3. Move down another icon. 4. Slowly move back up. The placeholder icon should eventually start going mental, bouncing between the below placeholder and the correct one every frame.
I'm unable to reproduce. Is this resolved?
I'm not comfortable with the previous title. Updating.
(In reply to comment #1) > I'm unable to reproduce. Is this resolved? No. (In reply to comment #2) > I'm not comfortable with the previous title. Updating. Agreed.
video showing dash icon placeholder erratic behavior on move of dash icon http://www.wupload.com/file/2636782112/Jumping_dash_icon_on_move_operation.ogv
Confirmed on my end too, its very noticeable when you grab the second last icon. Steps to reproduce for me (on gnome 3.2.1): 1.Set at least 3 icons to the dash and close all windows. (I used Nautilus, Chrome and Evolution respectively) 2.Grab the second last icon (Chrome in my case) 3.Drag icon roughly below the trash 4.Quickly but not too fast drag it back to where it was If done correctly there's a bit of a visual "freakout" on the dash
Created attachment 206193 [details] [review] Fix jumpy placeholder position Here is a patch that fixes this issue. The removed block was the guilty but I'm not sure what it was supposed to do. Anyway I didn't remark any side effects of this removal. Calculating the placeholder position regarding the dash height works fine but is a little bit tricky with the animations that modify the height (trash/placeholder animations).
Review of attachment 206193 [details] [review]: I think you attached the wrong patch.
Created attachment 206195 [details] [review] Fix jumpy placeholder position Sorry I posted the wrong patch.
(In reply to comment #8) > Created an attachment (id=206195) [details] [review] > Fix jumpy placeholder position > > Sorry I posted the wrong patch. Works for me. Thanks for the patch, Jean-Philippe.
Review of attachment 206195 [details] [review]: (In reply to comment #6) > Here is a patch that fixes this issue. The removed block was the guilty but I'm > not sure what it was supposed to do. It accounts for the additional height of a previous drag placeholder which is still visible (read: "animating out"); given that it is virtually impossible to trigger that case for anything but the faulty case here, removing that code looks right to me. Please provide a more verbose commit message though.
Pushed with a more verbose commit message - thanks again for the patch!
Yeah, thanks Jean-Philippe!