After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651788 - [theoraenc] separate encode and push block in theora_enc_chain
[theoraenc] separate encode and push block in theora_enc_chain
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-03 14:49 UTC by Luis de Bethencourt
Modified: 2011-06-15 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
separate encode and push block in chain, into own function. (4.83 KB, patch)
2011-06-03 14:50 UTC, Luis de Bethencourt 		committed Details | Review

Description Luis de Bethencourt 2011-06-03 14:49:40 UTC 
the encode and push block in theora_enc_chain could be separated into it's own function. improving the readability of the code, and making theora_enc_chain smaller.

http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/theora/gsttheoraenc.c#n1294
Comment 1 Luis de Bethencourt 2011-06-03 14:50:22 UTC 
Created attachment 189161 [details] [review]
separate encode and push block in chain, into own function.
Comment 2 Sebastian Dröge (slomo) 2011-06-04 08:11:34 UTC 
commit 8b18508778a6a13105794bf8c6fe61ce61cb1e6f
Author: Luis de Bethencourt <luis.debethencourt@collabora.como>
Date:   Fri Jun 3 16:29:00 2011 +0200

    theora: separate encode and push block in chain, into own function.