After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651606 - Wrong superclass used in NMNetworkMenuItem destroy ?
Wrong superclass used in NMNetworkMenuItem destroy ?
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-01 02:38 UTC by Dan Williams
Modified: 2011-06-02 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: fix chaining of a destroy method (753 bytes, patch)
2011-06-02 13:30 UTC, Dan Winship 		committed Details | Review

Description Dan Williams 2011-06-01 02:38:57 UTC 
NMNetworkMenuItem's destroy method does this:

        PopupMenu.PopupImageMenuItem.prototype.destroy.call(this);

But the class inherits from:

    __proto__: PopupMenu.PopupBaseMenuItem.prototype,


So should the destroy be calling up to PopupBaseMenuItem instead?
Comment 1 Giovanni Campagna 2011-06-01 12:34:49 UTC 
Yes, definitely.

Probably this was forgot when NMNetworkMenuItem started showing two icons.
Comment 2 Dan Winship 2011-06-02 13:30:31 UTC 
had no effect since ImageMenuItem didn't override BaseMenuItem's destroy
anyway (and also, we never destroy the network menu). But yeah.

The following fix has been pushed:
7f2456c network: fix chaining of a destroy method
Comment 3 Dan Winship 2011-06-02 13:30:34 UTC 
Created attachment 189078 [details] [review]
network: fix chaining of a destroy method