After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651219 - fix path to true(1) on OpenBSD
fix path to true(1) on OpenBSD
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.28.x
Other OpenBSD
: Normal trivial
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-05-27 08:22 UTC by Antoine Jacoutot
Modified: 2011-06-06 00:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
true(1) is under /usr/bin on OpenBSD (714 bytes, patch)
2011-05-27 08:22 UTC, Antoine Jacoutot 		reviewed Details | Review
Don't hardcode path to true(1). (691 bytes, patch)
2011-05-27 15:44 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review
Don't hardcode path to true(1). (742 bytes, patch)
2011-05-27 16:01 UTC, Matthias Clasen 		committed Details | Review

Description Antoine Jacoutot 2011-05-27 08:22:27 UTC 
Created attachment 188731 [details] [review]
true(1) is under /usr/bin on OpenBSD

All is in the subject :)
Comment 1 Colin Walters 2011-05-27 15:30:09 UTC 
Review of attachment 188731 [details] [review]:

You guys appear to have a default of simply inserting #ifdef __OpenBSD__, which is annoying.  The default thought process should be "how can I fix this problem elegantly?"  Where "elegantly" means we likely won't have to also take an #ifdef for NetBSD or whatever too.

In this case - system() searches $PATH, so why don't we just take out the path prefix?
Comment 2 Antoine Jacoutot 2011-05-27 15:43:47 UTC 
Sorry I didn't mean to upset you. It was hard-coded in the first place which was not "elegant" either. I was just trying to be consistent with the history of the code.
Comment 3 Antoine Jacoutot 2011-05-27 15:44:22 UTC 
Created attachment 188769 [details] [review]
Don't hardcode path to true(1).
Comment 4 Matthias Clasen 2011-05-27 16:01:47 UTC 
Thanks.

The following fix has been pushed:
2ee470a Don't hardcode path to true(1).
Comment 5 Matthias Clasen 2011-05-27 16:01:52 UTC 
Created attachment 188772 [details] [review]
Don't hardcode path to true(1).

true(1) is not always installed under /bin so leave system() find
it in the PATH.
Comment 6 Colin Walters 2011-05-27 16:02:56 UTC 
Review of attachment 188769 [details] [review]:

Not upset; I just take pride in good code =)
Comment 7 Ryan Schmidt 2011-06-06 00:48:31 UTC 
Thanks on behalf of MacPorts for fixing this. We've been having to patch it locally for years.