After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651135 - Crash using saved search with an empty expression
Crash using saved search with an empty expression
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
3.0.x (obsolete)
Other Linux
: Normal critical
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-05-26 11:00 UTC by Milan Crha
Modified: 2011-05-26 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (729 bytes, patch)
2011-05-26 11:46 UTC, Milan Crha
committed Details | Review

Description Milan Crha 2011-05-26 11:00:30 UTC
Moving this from a downstream bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=707713

Steps:
a) go to contacts
b) create a new Search by Search->Edit saved searches->Add
c) make it "Expression" and keep the expression itself empty
d) save the search
e) Search->that-new-search

Evolution crashes when selecting this search in e).

Thread 1 (Thread 0xb7821880 (LWP 22559))

  • #0 e_book_query_to_string
    at e-book-query.c line 669
  • #1 e_addressbook_model_set_query
  • #2 book_shell_view_execute_search
    at e-book-shell-view.c line 241

Comment 1 Milan Crha 2011-05-26 11:46:57 UTC
Created attachment 188657 [details] [review]
evo patch

for evolution;

I can reproduce this too, on a git master. There was a warning on the console too:
> libebook-WARNING **: conversion to EBookQuery failed

This patch prevents crash by ignoring such "broken" queries. The UI shows it's filtering, but this query has no effect on the view itself.
Comment 2 Milan Crha 2011-05-26 11:51:24 UTC
Created commit 1993a29 in evo master (3.1.2+)
Created commit af08ff1 in evo gnome-3-0 (3.0.3+)