After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651054 - Support queries based on "photo" contact field
Support queries based on "photo" contact field
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-05-25 11:59 UTC by Christophe Dumez
Modified: 2011-06-01 17:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.90 KB, patch)
2011-05-25 11:59 UTC, Christophe Dumez 		committed Details | Review

Description Christophe Dumez 2011-05-25 11:59:53 UTC 
Created attachment 188581 [details] [review]
Proposed patch

Hi,

I'm currently working on the QtContacts backend for EDS part of MeeGo.

libebook currently does not support queries based on the "photo" EContact field such as (is "photo" "http://localhost/me.png"). This is due to the fact that the "photo" field has a complex EContactPhoto type.

This behavior can be improved by comparing with the uri property in the EContactPhoto struct, if available (only URI matching makes sense anyway).

Please find attached a patch proposal. I checked that it works with my unit tests.
Comment 1 Milan Crha 2011-05-25 14:08:19 UTC 
Looks good and may not hurt older code either, thus I'm approving it. Please commit to master only.
Comment 2 Milan Crha 2011-05-27 13:38:24 UTC 
Created commit ac16f4a in eds master (3.1.2+)
Comment 3 David Woodhouse 2011-05-31 11:55:27 UTC 
I appreciate that this is a new feature, but it's very simple and it would be useful to have it in 3.0 (and 2.32). Is it OK if I cherry-pick it into gnome-3-0?
Comment 4 Milan Crha 2011-06-01 17:09:17 UTC 
Sure, you can use it on stable branch too. It's not much a new feature from my point of view, I only wanted more testing on this in the master branch, and because Christopher is tight to 2.32.3 anyway, then it didn't seem to be a problem.