GNOME Bugzilla – Bug 65101
sheet names not quoted
Last modified: 2004-12-22 21:47:04 UTC
This problem is similar tot eh two-byte japanes sheet name problem discussed on the gnumeric list: Rename a sheet to "A,1" choose Correlation Analysis tool select a range on the sheet A,1 since the sheet name is not quoted the okay button doesn't become active. reason: static char quote_chr [] = { '=', '<', '>', '(', ')', '+', '-', ' ', '^', '&', '%', ':', '/', '*', '\\', '`', '\'', '´', '\0'}; doesn't include ',' Solution: we should rewrite sheet_name_quote such that all characters but alphanumerics cause quoting. (This may also solve the japanese two-byte problem)
Good idea. This also demonstrated a bug in the original routine. I'll commit the patch shortly.
You may or may not have noticed that your patch doesn't fix the described situation. It did fix the similar situation for the t-test tool or any situation expecting a single range. There is another bug in the global_range_list_parse code: it doesn't differentiate between commas in sheet names and elsewhere. I have fixed that bug and will be sending you a diff shortly.