After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650939 - Cleanup empathy-avatar-chooser
Cleanup empathy-avatar-chooser
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-24 06:55 UTC by Guillaume Desmottes
Modified: 2011-06-01 10:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=avatar-clean-up-650939 (64.97 KB, patch)
2011-05-26 09:12 UTC, Guillaume Desmottes 		none Details | Review

Description Guillaume Desmottes 2011-05-24 06:55:55 UTC 
This file is pretty nasty to read/review as a bunch of function steals ownership of ref/strings. We should clean that up; empathy_avatar_new() for example shouldn't steal ownership.
Comment 1 Guillaume Desmottes 2011-05-24 06:58:26 UTC 
Let's finish bug #521747 first.
Comment 2 Guillaume Desmottes 2011-05-26 09:12:51 UTC 
Created attachment 188642 [details] [review]
http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=avatar-clean-up-650939

 libempathy-gtk/empathy-avatar-chooser.c | 1856 +++++++++++++++----------------
 libempathy-gtk/empathy-avatar-chooser.h |   44 +-
 libempathy/empathy-contact.c            |   33 +-
 libempathy/empathy-contact.h            |    6 +-
 4 files changed, 966 insertions(+), 973 deletions(-)
Comment 3 Guillaume Desmottes 2011-05-26 09:13:36 UTC 
Probaby best to review commit by commit, I did some cleanup while I was on it.
Comment 4 Emilio Pozuelo Monfort 2011-06-01 09:16:53 UTC 
First commit's message: choose -> chooser.

Looks good otherwise!
Comment 5 Guillaume Desmottes 2011-06-01 10:01:55 UTC 
Merged to master; thanks.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.