After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650884 - fix compilation with gcc2
fix compilation with gcc2
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.28.x
Other OpenBSD
: Normal trivial
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-05-23 16:17 UTC by Antoine Jacoutot
Modified: 2011-05-23 17:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gcc2 fix patch 1 (744 bytes, patch)
2011-05-23 16:17 UTC, Antoine Jacoutot 		none Details | Review
gcc2 fix patch 2 (1.06 KB, patch)
2011-05-23 16:17 UTC, Antoine Jacoutot 		reviewed Details | Review
fix build on gcc2 (2.25 KB, patch)
2011-05-23 17:13 UTC, Antoine Jacoutot 		committed Details | Review

Description Antoine Jacoutot 2011-05-23 16:17:08 UTC 
Created attachment 188398 [details] [review]
gcc2 fix patch 1

Hi.

On OpenBSD we use these 2 patches to be able to compile glib with gcc2 (yeah, some of our old supported arches still use gcc2).

Thoughts?
Comment 1 Antoine Jacoutot 2011-05-23 16:17:25 UTC 
Created attachment 188399 [details] [review]
gcc2 fix patch 2
Comment 2 Colin Walters 2011-05-23 16:57:02 UTC 
Review of attachment 188399 [details] [review]:

Can you resubmit this fix in "git format-patch" style?
http://live.gnome.org/GnomeLove/SubmittingPatches
Comment 3 Antoine Jacoutot 2011-05-23 17:13:40 UTC 
Created attachment 188408 [details] [review]
fix build on gcc2
Comment 4 Colin Walters 2011-05-23 17:27:07 UTC 
Review of attachment 188408 [details] [review]:

Looks good, thanks.