Given that the code for converting the strength to the icon is the same in both cases, I guess that something was not updated. Do you see anything strange in .xsession-errors?

Nothing relevant in there.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Still happening in 3.2.1.

(In reply to comment #3)
> Still happening in 3.2.1.

I believe it is because notify::strength is not emitted reliably by libnm-glib (and we update the icons at different times in the indicator and in the menu).
I've added some logging to my local copy, let's see what turns out.

Created attachment 200248 [details] [review]
NetworkMenu: fix logic for updating wifi icon

Previously, we connected to notify::strength only if there was
already a signal connected, and the AP changed (thus, by induction,
we never connected). As a result, the icon became stale and different
from that shown inside the menu (which is correctly updated).

Review of attachment 200248 [details] [review]:

Can connecting to the same AP twice in a row happen? If yes, I'd like to see my review comments addressed. If no, treat this as ACN.

::: js/ui/status/network.js
@@ +2066,3 @@
                         this.setIcon('network-wireless-connected');
                     } else {
+                        if (this._accessPointUpdateId)

This is still inefficient for connecting to the same AP twice. How about:

if (this._activeAccessPoint != ap) {
    if (this._accessPointUpdateId > 0)
        this._activeAccessPoint.disconnect(this._accessPointUpdateId;
    this._activeAccessPoint = ap;
    this._activeAccessPointUpdateId = ap.connect(...);
}

@@ +2095,3 @@
                 }
 
+                if (this._mobileUpdateId)

Same for down here.

Created attachment 200585 [details] [review]
NetworkMenu: fix logic for updating wifi icon

Previously, we connected to notify::strength only if there was
already a signal connected, and the AP changed (thus, by induction,
we never connected). As a result, the icon became stale and different
from that shown inside the menu (which is correctly updated).

---

Yes, _updateIcon can be called multiple time even if the primary
connection is the same, so what you proposed is a real performance improvement.

Review of attachment 200585 [details] [review]:

LGTM.

Attachment 200585 [details] pushed as d7d5da0 - NetworkMenu: fix logic for updating wifi icon