GNOME Bugzilla – Bug 649841
encodebin: Add formatters support
Last modified: 2018-11-03 11:18:53 UTC
The attached patch is an initial attempt at autoplugging formatters for each stream on the profile. This patch makes it pick the first formatter it finds, testing it with an mp3 profile and bumping xingmux rank made it pick it successfully. One decision to make is how many formatters are we going to plug? All available? First found? Best rank?
Created attachment 187536 [details] [review] encodebin: Autoplug formatters
The decision which formatters to use and in which order is a bit tricky. Did you check which formatters exist and do you have a list?
Not really, I was aiming at 2 use cases: lamemp3enc ! xingmux ! id3mux and jpegenc ! jifmux Not sure if we can accomplish the first one easily.
I guess the first step is to give non-zero ranks to formatters, should those be primary?
Patch looks good, the typo/docs could maybe be split up as a separat commit. As for the formatters, we should test them thoroughly before bumping the ranks. SECONDARY would be a good first start.
Pushed the patch (with minor fixes and the typos removed) as it should solve some use cases. We still need to figure out how to handle id3mux and xingmux for mp3 format. commit b5fb542386594ed690e739aed9ba31189d8d9203 Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk> Date: Thu May 19 08:30:14 2011 -0300 encodebin: Autoplug formatters Autoplug formatters for streams if a formatter with secondary or higher rank is found. Formatters are autoplugged when there is no muxer or when the muxer doesn't implement the tagsetter interface. Currently only the first formatter found is plugged, this might help in lots of cases, but it doesn't solve the 'lamemp3 ! xingmux ! id3mux' case. https://bugzilla.gnome.org/show_bug.cgi?id=649841
*** Bug 754623 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/48.