After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649670 - Without system try it's impossible to use Tasque
Without system try it's impossible to use Tasque
Status: RESOLVED FIXED
Product: Tasque
Classification: Other
Component: General
git
Other Linux
: Normal major
: ---
Assigned To: tasque-maint
tasque-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-07 16:37 UTC by Alessio Caiazza
Modified: 2012-09-21 01:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
AppIndicator API implementation (8.57 KB, patch)
2011-05-07 16:37 UTC, Alessio Caiazza
none Details | Review

Description Alessio Caiazza 2011-05-07 16:37:57 UTC
Created attachment 187432 [details] [review]
AppIndicator API implementation

Unity, in the last Ubuntu, doesn't have a system tray, so it's hard to work with tasque.

They are supporting the new App Indicator model[1] and there is a c# implementation; libappindicator-sharp

With this patch I collapsed the tooltips and the system tray into the AppIndicator.

I'm not familiar with automake/autoconf but I managed to add a ENABLE_APPINDICATOR_SHARP define which excludes the AppIndicator code if the compile machine doesn't have libappindicator-sharp.

Some details:

Application.SetupAppIndicator() creates an AppIndicator menu which has the same items of the PopupMenu (items are linked to the same action); It has also a status label which is managed in Application.RefreshTrayIconTooltip() and a 'tasque' entry for toggling window visibility (like the TrayIcon click).
This method must be run before StartMainLoop().
Glitch: I've no idea where AppIndicator looks for icons, but if you don't have tasque installed it will fail to find 'tasque-24' icon and will not display anything.

I've extracted the tooltip string generation from Application.RefreshTrayIconTooltip() to Application.GenerateTooltip() in order to use it also for AppIndicator status.



[1] https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators
Comment 1 Antonius Riha 2012-09-09 09:33:44 UTC
Thanks, this has already been resolved in 0.1.11 Fresh Milk!.
Comment 2 Antonius Riha 2012-09-21 01:39:00 UTC
After reviewing your patch again, I noticed the workaround for the tooltip on appindicator. Though I wasn't able to pull your patch entirely (because the base trees have diverged too much), I applied your idea to the current appindicator implementation. Thanks!