GNOME Bugzilla – Bug 649632
workspace: various fixes for window zooming
Last modified: 2013-03-03 22:42:39 UTC
The Main.uiGroup thing has been bugging me for a little while, and while trying to reproduce a crasher, I found this other bug, which pretty much messes up your entire system because of the reparent.
Created attachment 187408 [details] [review] workspace: various fixes for window zooming Don't use global.stage directly, use Main.uiGroup instead. When dragging a window, make sure to end the zoom if it exists, otherwise there are some weird side effects.
Review of attachment 187408 [details] [review]: These should be two separate patches. Can you explain how to reproduce the first problem? ::: js/ui/workspace.js @@ +298,3 @@ _onDragBegin : function (draggable, time) { + if (this._zooming) + this._zoomEnd(); This one looks fine.
Use the magnifier.
Created attachment 187668 [details] [review] workspace: Use Main.uiGroup instead of global.stage The mouse-wheel zoom "easter egg" broke when using the magnifier because it was using global.stage. Fix it to use Main.uiGroup instead.
Created attachment 187669 [details] [review] workspace: End zooming when starting a window drag The mouse-wheel zooming "easter egg" breaks horribly when you drag a window, due to ugly lightbox reparenting tricks it uses. For now, just end any zoom before we drag the window around.
Review of attachment 187669 [details] [review]: Looks good.
Review of attachment 187668 [details] [review]: Looks good.
Attachment 187668 [details] pushed as bc2b479 - workspace: Use Main.uiGroup instead of global.stage Attachment 187669 [details] pushed as 6e6b1e6 - workspace: End zooming when starting a window drag
The "End zooming when starting a window drag" ends up with the drag point possibly quite radically wrong. It's minor, but polish matters.
Zooming has been removed.