After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649195 - [miniobject] Fix dup_mini_object function to handle NULL gvalues
[miniobject] Fix dup_mini_object function to handle NULL gvalues
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal blocker
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-02 14:48 UTC by Thiago Sousa Santos
Modified: 2011-05-03 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
miniobject: Fix dup_mini_object function to handle NULL gvalues (2.72 KB, patch)
2011-05-02 14:48 UTC, Thiago Sousa Santos 		committed Details | Review

Description Thiago Sousa Santos 2011-05-02 14:48:06 UTC 
Attached patch to make gst_value_dup_mini_object behave just like
g_value_dup_object
Comment 1 Thiago Sousa Santos 2011-05-02 14:48:09 UTC 
Created attachment 187040 [details] [review]
miniobject: Fix dup_mini_object function to handle NULL gvalues

g_value_dup_object handles gvalues that contain NULL pointers,
gst_value_dup_mini_object should do the same.
Comment 2 Sebastian Dröge (slomo) 2011-05-03 07:30:15 UTC 
I guess this is related to bug #649227 ? IMHO we should get this into this release
Comment 3 Thiago Sousa Santos 2011-05-03 10:48:16 UTC 
(In reply to comment #2)
> I guess this is related to bug #649227 ? IMHO we should get this into this
> release

Exactly, to set miniobjects properties to NULL from python you need both fixes.
Comment 4 Tim-Philipp Müller 2011-05-03 11:00:43 UTC 
Comment on attachment 187040 [details] [review]
miniobject: Fix dup_mini_object function to handle NULL gvalues

Looks like a good thing to fix, and should be harmless.
Comment 5 Thiago Sousa Santos 2011-05-03 11:16:53 UTC 
commit a750aac2dd59453a875d19abf75d0203b217a77d
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Mon May 2 11:30:06 2011 -0300

    miniobject: Fix dup_mini_object function to handle NULL gvalues
    
    g_value_dup_object handles gvalues that contain NULL pointers,
    gst_value_dup_mini_object should do the same.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=649195