After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648938 - --enable-gtk2-dependency should also disable gtk-update-icon-cache.exe.manifest
--enable-gtk2-dependency should also disable gtk-update-icon-cache.exe.manifest
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-04-29 12:40 UTC by Kalev Lember
Modified: 2011-04-29 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Disable gtk-update-icon-cache.exe.manifest with --enable-gtk2-dependency (924 bytes, patch)
2011-04-29 12:43 UTC, Kalev Lember 		committed Details | Review

Description Kalev Lember 2011-04-29 12:40:17 UTC 
--enable-gtk2-dependency option disables building gtk-update-icon-cache.exe, but it currently doesn't disable building and installing gtk-update-icon-cache.exe.manifest.
Comment 1 Kalev Lember 2011-04-29 12:43:10 UTC 
Created attachment 186878 [details] [review]
Disable gtk-update-icon-cache.exe.manifest with --enable-gtk2-dependency

When gtk-update-icon-cache building is suppressed, its manifest file
should also not be installed.
Comment 2 Colin Walters 2011-04-29 14:03:56 UTC 
Review of attachment 186878 [details] [review]:

Also looks correct (though the nested conditionals here are...ugh).
Comment 3 Colin Walters 2011-04-29 14:26:32 UTC 
Attachment 186878 [details] pushed as bcc153e - Disable gtk-update-icon-cache.exe.manifest with --enable-gtk2-dependency