After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648929 - [tsdemux] Memory leaks everywhere
[tsdemux] Memory leaks everywhere
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal major
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-29 10:46 UTC by Edward Hervey
Modified: 2011-04-29 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tsdemux: Free packet buffer even if it doesn't have a payload (864 bytes, patch)
2011-04-29 10:47 UTC, Edward Hervey
committed Details | Review
mpegtsbase: Don't forget to free the program streams array (853 bytes, patch)
2011-04-29 10:47 UTC, Edward Hervey
committed Details | Review
mpegtsbase: Unref buffers we don't use. (922 bytes, patch)
2011-04-29 10:47 UTC, Edward Hervey
committed Details | Review
tsdemux: Don't leak bufferlist on streams without pads (902 bytes, patch)
2011-04-29 10:47 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2011-04-29 10:46:55 UTC
tsdemux is leaking input, output, stream tables, etc...

Playing a 60MB file results in a 30MB leak.
Comment 1 Edward Hervey 2011-04-29 10:47:35 UTC
Created attachment 186866 [details] [review]
tsdemux: Free packet buffer even if it doesn't have a payload

This can happen with AFC-only packets. Avoids leaking buffers.
Comment 2 Edward Hervey 2011-04-29 10:47:38 UTC
Created attachment 186867 [details] [review]
mpegtsbase: Don't forget to free the program streams array
Comment 3 Edward Hervey 2011-04-29 10:47:41 UTC
Created attachment 186868 [details] [review]
mpegtsbase: Unref buffers we don't use.

Avoids a massive leak :)
Comment 4 Edward Hervey 2011-04-29 10:47:44 UTC
Created attachment 186869 [details] [review]
tsdemux: Don't leak bufferlist on streams without pads
Comment 5 Edward Hervey 2011-04-29 14:20:23 UTC
commit 21add205b7921cbae5619a09178ab370f4e71675
Author: Edward Hervey <edward.hervey@collabora.co.uk>
Date:   Fri Apr 29 12:39:38 2011 +0200

    tsdemux: Don't leak bufferlist on streams without pads
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648929

commit 565f06804953203101aea26fb26cd110fb9b12d3
Author: Edward Hervey <edward.hervey@collabora.co.uk>
Date:   Fri Apr 29 12:38:31 2011 +0200

    mpegtsbase: Unref buffers we don't use.
    
    Avoids a massive leak :)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648929

commit c26ca36cf08b8a6108fb855cdc79e6a025768439
Author: Edward Hervey <edward.hervey@collabora.co.uk>
Date:   Fri Apr 29 12:08:38 2011 +0200

    mpegtsbase: Don't forget to free the program streams array
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648929

commit 390502a093e15a009516be41342b0cc0b6d68f53
Author: Edward Hervey <edward.hervey@collabora.co.uk>
Date:   Fri Apr 29 12:08:04 2011 +0200

    tsdemux: Free packet buffer even if it doesn't have a payload
    
    This can happen with AFC-only packets. Avoids leaking buffers.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648929