Created attachment 186738 [details] [review]
StScrollBar: use clutter_actor_has_allocation()

StScrollBar was tracking whether or not it currently had a valid
allocation, but since Clutter 1.4 there is a method it can call to get
that information instead.

Created attachment 186739 [details] [review]
StImText: remove two references to old clutter bugs

Remove a workaround for clutter_actor_get_transformed_position() not
working inside paint(), and remove a comment about
ClutterText::position not being properly notified, since it is now.
(However, it doesn't seem worth it to rewrite the code to use
notification, since that would actually end up being more complicated
than the current solution.)

Created attachment 186740 [details] [review]
ShellRecorder: Use cogl_read_pixels()

cogl_read_pixels() used to only support a useless pixel format, but it
will do our preferred format now, so use it rather than doing GL stuff
by hand.

poke

Review of attachment 186738 [details] [review]:

Yeah this makes sense and the code looks good to me.

Review of attachment 186739 [details] [review]:

Looks good.

Review of attachment 186740 [details] [review]:

The disadvantage of doing it this way is that we lose the GL_MESA_pack_invert support but it wasn't really that much of a gain anyway (and if we really want it it should be in cogl) so this is fine as well.

Attachment 186738 [details] pushed as 55771b4 - StScrollBar: use clutter_actor_has_allocation()
Attachment 186739 [details] pushed as c5ca4e3 - StImText: remove two references to old clutter bugs
Attachment 186740 [details] pushed as 619a44a - ShellRecorder: Use cogl_read_pixels()