After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648706 - Wrong assumptions about word order
Wrong assumptions about word order
Status: RESOLVED FIXED
Product: frogr
Classification: Other
Component: general
master
Other All
: Normal normal
: ---
Assigned To: frogr maintainers
frogr maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-26 21:12 UTC by Claude Paroz
Modified: 2011-04-27 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Claude Paroz 2011-04-26 21:12:41 UTC 
In several places in frogr, you are doing string concatenation in a suboptimal way regarding internationalization, that is you supposed that all languages are using the same word order.

Example:
    g_strdup_printf (" - %s %s", total_size_str, _("to be uploaded"));

You should provide the %s in the translatable string, telling what they contain, so as to allow the translator to swap word order if needed (untested code):

    /* Translators: %s is a size (KB, MB or GB) */
    g_strdup_printf ( _(" - %s to be uploaded"), total_size_str);

I know, it's not always easy to do properly...
Comment 1 Mario Sánchez Prada 2011-04-26 23:01:34 UTC 
You're right... I have to recognize I did a poor job so far with the translatable strings, but I'd love to see that fixed for the next release, so I'll try to cook a patch for those cases I can find.

Or if you want to step in and provided a patch yourself I'd love to integrate it right away. After all, it's obvious you know better than me about this stuff :-)
Comment 2 Mario Sánchez Prada 2011-04-27 13:45:57 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

http://git.gnome.org/browse/frogr/commit/?id=826d085b4897a437a9fc42522c47c881559467e7
Comment 3 Claude Paroz 2011-04-27 14:48:33 UTC 
Thanks Mario, very much better now!