GNOME Bugzilla – Bug 648555
[regression] places-sidebar doesn't open selected item on enter
Last modified: 2011-04-25 17:47:39 UTC
in bookmarks_key_press_event_cb () we use get_cursor () to open the current item; however, in the same function we use gtk_tree_selection_select_iter () to set it on up/down keypresses. these two calls don't play along: tree cursor != tree selection. the attached patch fixes this issue by using gtk_tree_model_get_selection () instead. (I'd rather not use _set_cursor () because AFAICS that would open the selected item when pressing up/down, which is quite annoying when moving through the sidebar with keynav only.) please review.
Created attachment 186554 [details] [review] proposed patch against git master
Thanks for your patch Stefano, I pushed it to master so that it will be in today's 3.0.1 tarball.