After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648338 - gck test LDADD ignores a couple lines (build failure)
gck test LDADD ignores a couple lines (build failure)
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: gck
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-04-20 23:03 UTC by Travis Reitter
Modified: 2019-03-23 21:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Travis Reitter 2011-04-20 23:03:43 UTC 
I noticed this:

LDADD =  \
        $(top_builddir)/gck/libgck.la \
        $(top_builddir)/egg/libegg-test.la \
        $(GTHREAD_LIBS) \
        $(GLIB_LIBS)
        $(GIO_LIBS) \
        libmock-test-module.la

The line with $(GLIB_LIBS) should end with a \

As it is now, the GIO_LIBS and libmock-test-module.la arguments are silently ignored by automake. It's a fun little massive bug in automake that's wasted a bit of my time too.

Adding the \ fixes a build error I hit (where the linker complains that g_object_unref is undefined). I'm not completely sure why it hits that error, since it should be a matter of missing libmock-test-module or GIO symbols, though.
Comment 1 Stef Walter 2011-04-21 07:43:05 UTC 
(In reply to comment #0)
> As it is now, the GIO_LIBS and libmock-test-module.la arguments are silently
> ignored by automake. It's a fun little massive bug in automake that's wasted a
> bit of my time too.

Thanks. Fixed in gnome-3-0 and master.

commit 433e014654564fb7dfe013c7968c4b9c027a6f34
Author: Stef Walter <stefw@collabora.co.uk>
Date:   Thu Apr 21 09:35:28 2011 +0200

    gck: Fix linking issue due to type in Makefile.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648338


> Adding the \ fixes a build error I hit (where the linker complains that
> g_object_unref is undefined). I'm not completely sure why it hits that error,
> since it should be a matter of missing libmock-test-module or GIO symbols,
> though.

"Oh who can know the ways of libtool?"