GNOME Bugzilla – Bug 648048
the bluetooth switch in the top right should tell you when bluetooth is turned off
Last modified: 2011-06-27 15:22:17 UTC
Created attachment 186165 [details] bluetooth menu behavior If I go into bluetooth settings, it tells me bluetooth has been disabled by a switch on my computer (indeed it has). However when I click on the icon in the upper right corner of the screen it has an on/off switch that cannot be toggled. In other words when one (see attachment) knows about two it should behave like three
Created attachment 186432 [details] [review] PopupMenu: move PopupStatusSwitchMenuItem out of network.js Moves and converts NMDeviceTitleMenuItem from network.js into PopupStatusSwitchMenuItem, that is a menu item that can show both a switch and a greyed-out status label. This will be soon used by the Bluetooth menu.
Created attachment 186433 [details] [review] BluetoothStatus: show "hardware disabled" when disabled by rfkill Use the new PopupStatusSwitchMenuItem and set it appropriately when bluetooth cannot be enabled. Use it also for showing "connecting..." when activating device items.
Comment on attachment 186432 [details] [review] PopupMenu: move PopupStatusSwitchMenuItem out of network.js >+PopupStatusSwitchMenuItem.prototype = { would it make more sense to just merge this functionality into PopupSwitchMenuItem? >+ PopupMenu.PopupStatusSwitchMenuItem.prototype._init.call(this, label, 'popup-subtitle-menu-item', params); should it default to { style_class: 'popup-subtitle-menu-item' }, since you set that everywhere you use it?
Comment on attachment 186433 [details] [review] BluetoothStatus: show "hardware disabled" when disabled by rfkill looks right
Created attachment 187519 [details] [review] PopupMenu: enhance PopupSwitchMenuItem to show status labels Moves and converts NMDeviceTitleMenuItem from network.js into PopupSwitchMenuItem, so that it can show both a switch and a greyed-out status label. This will be soon used by the Bluetooth menu.
Created attachment 187520 [details] [review] BluetoothStatus: show "hardware disabled" when disabled by rfkill Use the new PopupSwitchMenuItem functionality when bluetooth cannot be enabled. Use it also for showing "connecting..." when activating device items.
Created attachment 187529 [details] [review] BluetoothStatus: show "hardware disabled" when disabled by rfkill Use the new PopupSwitchMenuItem functionality when bluetooth cannot be enabled. Use it also for showing "connecting..." when activating device items.
Created attachment 189329 [details] bluetooth discrepancy between system and applet
Comment on attachment 189329 [details] bluetooth discrepancy between system and applet I believe this is related to the current issue.
The design for the network menu is to show "disabled by hardware switch" when rfkilled.
(In reply to comment #10) > The design for the network menu is to show "disabled by hardware switch" when > rfkilled. Which is too long - that's why I changed the description.
Attachment 187519 [details] pushed as c867081 - PopupMenu: enhance PopupSwitchMenuItem to show status labels Attachment 187529 [details] pushed as 9412ac2 - BluetoothStatus: show "hardware disabled" when disabled by rfkill