After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648025 - parse-launch: don't unescape inside quotes
parse-launch: don't unescape inside quotes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-17 15:22 UTC by Miguel Angel Cabrera Moya
Modified: 2011-06-15 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bug fix + test case for the bug report (2.22 KB, patch)
2011-04-17 15:23 UTC, Miguel Angel Cabrera Moya 		none Details | Review
Bug fix + test case for the bug report (2.68 KB, patch)
2011-04-20 20:58 UTC, Miguel Angel Cabrera Moya 		committed Details | Review

Description Miguel Angel Cabrera Moya 2011-04-17 15:22:02 UTC 
Escaped characters inside quoted strings are supposed to be unescaped by deserialization functions, not by parsing functions.
Comment 1 Miguel Angel Cabrera Moya 2011-04-17 15:23:55 UTC 
Created attachment 186149 [details] [review]
Bug fix + test case for the bug report
Comment 2 Sebastian Dröge (slomo) 2011-04-18 07:38:51 UTC 
This looks like it could fail if you have a string like "bla\"bla". The second " would change the state to !in_quotes although it shouldn't because of the \. Could you add a test for that too please?
Comment 3 Miguel Angel Cabrera Moya 2011-04-20 20:58:36 UTC 
Created attachment 186394 [details] [review]
Bug fix + test case for the bug report

You were right Sebastian, i was missing that case. Now it works and also i added a new test case.
Comment 4 Sebastian Dröge (slomo) 2011-04-21 15:27:58 UTC 
Thanks, I'll push this after release.
Comment 5 Sebastian Dröge (slomo) 2011-05-14 09:58:50 UTC 
commit f450817d7f3a1dc46d481f7a2285fa0fb451132f
Author: Miguel Angel Cabrera Moya <madmac2501@gmail.com>
Date:   Wed Apr 20 22:52:36 2011 +0200

    parse: don't unescape inside quotes
    
    Escaped characters inside quoted strings are supposed to be unescaped by
    deserialization functions, not by parsing functions.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648025