GNOME Bugzilla – Bug 647976
New tabs with Ctrl+Enter open at the end of tab list
Last modified: 2011-04-18 20:04:53 UTC
Created attachment 186114 [details] [review] Use EPHY_NEW_TABS_APPEND_AFTER for all tabs opening I am guessing this is the new desired behaviour, but contextual opening of tabs that Epiphany used to have was much better. February commit 552b8f94003391ee8255ced943e333801906801c by Xan restores that for middle-click (well, partially, see below), but it doesn't work for at least another very much necessary case: Ctrl+Enter in the URL bar. My dumb fix for that is attached, but that makes all tabs to be opened next to the current one, even if the desired behavior is supposed to be that they open at the end. I personally find this much better anyway, but I do understand if patch cannot be committed as-is because of this. If it would be acceptable to modify the patch to at least provide this behaviour for Ctrl+Enter, I'd try to get that fixed as well. Also, implemention of EPHY_NEW_TABS_APPEND_AFTER seems to suffer from a new problem: new tab is always put exactly to the right of the current one, instead of at the end of the list of newly opened, unseen tabs. That's maybe extension material, but it's definitely a separate bug discussion, but mildly related so I wanted to bring it up :)
I also note that when pages request new windows to be opened (with target=_blank) and a setting of 'open new windows as tabs' on, they are still appended at the end. To be honest, I don't see a single reason for new tabs to ever be opened at the end, other than that other, broken browsers do it :)
First of all, it's unclear to me what are you complaining about exactly. Surely epiphany never did "contextual opening of tabs" by default? Are you talking about the extension? Second, there might certainly some places I forget to fix-up to make things consistent, we should find and fix them.
Review of attachment 186114 [details] [review]: This looks good, but please explain in the commit message that this applies to URLs opened from the entry (for example) and put a reference to the bug.
(In reply to comment #2) > First of all, it's unclear to me what are you complaining about exactly. Surely > epiphany never did "contextual opening of tabs" by default? Are you talking > about the extension? As a matter of fact, it did: http://mail.gnome.org/archives/epiphany-list/2004-September/msg00061.html :)
OK, fair, enough. s/never/not in the last 7 years/. My point is that I guess he was not talking about the default behavior of the browser.
Right, I did enjoy that even 7 years ago :), but ever since it was moved into extensions, I have had the tab grouping extension turned on, so I apologize for the confusion. I'd be happy to spend more time to get Epiphany to the state that tab-grouping extension (including APPEND_AFTER behaviour), but I'd have to first get myself better familiarized with Epiphany code. I'll be opening new bugs if that's better and marking this one as RESOLVED/FIXED. Anyway, committed to master and gnome-3-0 branches.