After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647972 - No text showing in the project list
No text showing in the project list
Status: RESOLVED FIXED
Product: giggle
Classification: Other
Component: UI: Browse View
HEAD
Other Linux
: Normal normal
: ---
Assigned To: giggle-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-16 22:10 UTC by J.P. Lacerda
Modified: 2011-04-18 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.00 KB, patch)
2011-04-16 22:10 UTC, J.P. Lacerda 		needs-work Details | Review
color (1.08 KB, patch)
2011-04-18 11:08 UTC, J.P. Lacerda 		committed Details | Review

Description J.P. Lacerda 2011-04-16 22:10:33 UTC 
Created attachment 186112 [details] [review]
patch

Currently, the foreground color is the same as the background color for cells under the project list (giggle-file-list.c), when the cell is in a non-ACTIVE state (i.e. NORMAL or INSENSITIVE).

The attached patch closes this bug.

J.P.
Comment 1 Javier Jardón (IRC: jjardon) 2011-04-17 20:43:55 UTC 
Comment on attachment 186112 [details] [review]
patch

Thanks for the patch :)

The patch is correct but not complete. The files that are not in the git tree should be greyed, so different from the ones that are in tree

Could you rework your patch to fix this?
Comment 2 J.P. Lacerda 2011-04-18 11:07:40 UTC 
Yes, here it is :)(In reply to comment #1)
> (From update of attachment 186112 [details] [review])
> Thanks for the patch :)
> 
> The patch is correct but not complete. The files that are not in the git tree
> should be greyed, so different from the ones that are in tree
> 
> Could you rework your patch to fix this?

Attached, thanks for your help! :)
Comment 3 J.P. Lacerda 2011-04-18 11:08:08 UTC 
Created attachment 186192 [details] [review]
color
Comment 4 Javier Jardón (IRC: jjardon) 2011-04-18 17:10:21 UTC 
Comment on attachment 186192 [details] [review]
color

commit 1c95814848cf9151530f8c80675df760558a4300
Comment 5 Javier Jardón (IRC: jjardon) 2011-04-18 17:10:41 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.