GNOME Bugzilla – Bug 647875
Use Cairo to dump the pick buffers
Last modified: 2011-05-06 14:12:01 UTC
Do not use GdkPixbuf, as all we want is pushing pixels to a PNG file. This has a couple of added bonuses: • removes the last lonely use of GdkPixbuf from Clutter • simplifies the code and reduces the memory management
Created attachment 186027 [details] [review] cairo-texture: Make the pixel order macro public It stands to reason that any piece of code using Cairo and Cogl at the same time, and dealing with texture data, will want to use the same logic Clutter uses to determine the compatible pixel format between the two.
Created attachment 186028 [details] [review] stage: Use Cairo to dump the pick buffer Do not use GdkPixbuf just for getting image data down into a PNG; Cairo is perfectly capable of doing the same, at least just for debugging purposes.
Created attachment 186214 [details] [review] cairo-texture: Make the pixel order macro public It stands to reason that any piece of code using Cairo and Cogl at the same time, and dealing with texture data, will want to use the same logic Clutter uses to determine the compatible pixel format between the two.
Created attachment 186215 [details] [review] stage: Use Cairo to dump the pick buffer Do not use GdkPixbuf just for getting image data down into a PNG; Cairo is perfectly capable of doing the same, at least just for debugging purposes.
Attachment 186214 [details] pushed as 3a071a4 - cairo-texture: Make the pixel order macro public Attachment 186215 [details] pushed as 00f2a39 - stage: Use Cairo to dump the pick buffer