After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647288 - Poor contrast for Critical/error infobars
Poor contrast for Critical/error infobars
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Lapo Calamandrei
gnome-themes-standard-maint
Depends on: 670555
Blocks:
 
 
Reported: 2011-04-09 16:07 UTC by Jean-François Fortin Tam
Modified: 2012-02-28 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
infobar color change patch (1.79 KB, patch)
2012-02-27 19:41 UTC, Lapo Calamandrei
none Details | Review
Screenshot (66.43 KB, image/png)
2012-02-27 19:42 UTC, Lapo Calamandrei
  Details
infobar text color change patch (2.83 KB, patch)
2012-02-27 21:03 UTC, Lapo Calamandrei
none Details | Review
Screenshot (65.90 KB, image/png)
2012-02-27 21:05 UTC, Lapo Calamandrei
  Details

Description Jean-François Fortin Tam 2011-04-09 16:07:43 UTC
As can be seen in attachment #185590 [details] (screenshot), black text on dark-red background is hard to read. It would be better if the red background can be made lighter (or white text on a darker red), or if the text had a white shadow for increased legibility.
Comment 1 Lapo Calamandrei 2012-02-21 12:05:22 UTC
Good point, my idea is to make the text white there, I wasn't able to achieve that via the theme though. Cosimo?
Comment 2 Lapo Calamandrei 2012-02-27 19:41:24 UTC
Created attachment 208509 [details] [review]
infobar color change patch

Changes text colors to white for error (red bg) and question (blue bg) infobars and to black for info (yellow bg) and warning (orange bg)
Comment 3 Lapo Calamandrei 2012-02-27 19:42:25 UTC
Created attachment 208510 [details]
Screenshot
Comment 4 Lapo Calamandrei 2012-02-27 21:03:18 UTC
Created attachment 208532 [details] [review]
infobar text color change patch

Same as the other one, but tweaking text shadows to improve readability
Comment 5 Lapo Calamandrei 2012-02-27 21:05:41 UTC
Created attachment 208533 [details]
Screenshot
Comment 6 Lapo Calamandrei 2012-02-28 17:44:54 UTC
commit e50bffa3ced85d6fa2a36f4c321441eef3f2f74d
Author: Lapo Calamandrei <calamandrei@gmail.com>
Date:   Tue Feb 28 18:42:06 2012 +0100

    Widgets: made text more readable on infobars, using white on
             error and question and black on info and warning.
             Closes #647288.