GNOME Bugzilla – Bug 647129
AlbumGrid/SortAlbumByYear: move configuration UI from Preferences to ViewMenu
Last modified: 2020-03-17 09:19:06 UTC
Add menu entries for disabling album grid and sorting tracks by album year to the view menu and remove them from the source preferences, so they are easier to find and more readily accessible.
Created attachment 185494 [details] [review] patch to move configuration UI to view menu
Created attachment 186704 [details] [review] patch to move configuration UI to view menu updated patch after merge conflict with master due to bgo#646991
(In reply to comment #2) > Created an attachment (id=186704) [details] [review] > patch to move configuration UI to view menu > > updated patch after merge conflict with master due to bgo#646991 Without reviewing the patch yet, I would like to review the "approach" first. Why is it bad to have these options in the preferences? I mean, having them in the menu makes them more accessible, but: a) Accessibility is normally good when an option is changed often. For things like Fullscreen, Show Context Pane, Show Cover Art, it makes sense, but not sure if it makes sense for this. b) If we ignore (a) and I got to write a patch to move them somewhere more accessible, I would actually do it in an ever more accessible and intuitive place: the context menu when clicking on the album view. But even if I wrote a patch for (b), I would not remove the options from the preferences because of two reasons: 1) Duplicated preferences are not a bad thing: users may find them in different circumstances when using the program. 2) Removing the "Disable album grid" option from the preferences prevents me from writing a patch that I was thinking to do, to rework this option to read: [ ] Enable album grid. Size: [50]v (This is bug 614687) What do you think?
This patch was actually motivated by various other patches that add GUI configuration options: - enhanced artist view - optional genre and year column - artist column displays either all artists or all album artists These patches introduce more options that actually fit nicely in the View menu, where the browser (that's what it is about) was originally configured (top/left view). Gabriel was the one that pointed out (and I agree) that the View menu is the obvious place for all options that are changing the view of anything. Since many options in there are not Music-Library specific, it is undesirable to have View options in source-specific tabs, but it is desirable to have all View options in one place and visible when applicable. The whole menu would look much more complex if above mentioned patches were to be applied: http://bugzilla-attachments.gnome.org/attachment.cgi?id=188568 (from bug https://bugzilla.gnome.org/show_bug.cgi?id=540873)
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.