After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646993 - fuzzyborder.scm has typos and uses a deprecated function
fuzzyborder.scm has typos and uses a deprecated function
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Script-Fu
git master
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2011-04-07 07:27 UTC by Patrick Horgan
Modified: 2011-08-23 18:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the problem. (1.58 KB, patch)
2011-04-07 07:27 UTC, Patrick Horgan 		none Details | Review

Description Patrick Horgan 2011-04-07 07:27:08 UTC 
Created attachment 185392 [details] [review]
Patch to fix the problem.

On lines 90 and 99 it has inImage when it means theImage and it uses a deprecated method.
Comment 1 Michael Natterer 2011-04-07 09:46:37 UTC 
Thanks, looks absolutely right :)
Comment 2 Kevin Cozens 2011-08-23 17:49:58 UTC 
At first glance it may look correct but it is not. There are three issues with this script.

First, if you change inImage to theImage in line 90, the original image will be left with an active selection when the script completes. Second, the function gimp-image-select-item which fixes the deprecation is affected by three different context settings. To get consistent results from the script a call to gimp-context-set-defaults is needed after gimp-context-push. Third, if you select "Add shadow" the script aborts in line 100 (the call to gimp-image-insert-layer) with an error. The exact error is:

Procedure 'gimp-image-insert-layer' has been called with an invalid ID for argument 'layer'. Most likely a plug-in is trying to work on a layer that no longer exists. 

The third issue is a pre-existing condition unrelated to the suggested patch.
Comment 3 Kevin Cozens 2011-08-23 18:05:11 UTC 
commit 0124c29df159f0acdfc1a321b28cfdb074dc39cd
Author: Kevin Cozens <kcozens@svn.gnome.org>
Date:   Tue Aug 23 13:59:28 2011 -0400

    Fixed deprecation warning and script breakage (see bug #646993)
    
    Fixed deprecation warning. Fixed script breakage when "Add shadow" was checked
    due to error in order of arguments. Made chris-color-edge a private procedure.

P.S. I can't mark patch as rejected due to a current bug in bugzilla.