After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646952 - Fix the strlol return type mismatch :
Fix the strlol return type mismatch :
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-06 20:13 UTC by sreerenj
Modified: 2011-04-12 10:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the return type mismatch in gstrtsptransport. (1.85 KB, patch)
2011-04-06 20:13 UTC, sreerenj 		committed Details | Review

Description sreerenj 2011-04-06 20:13:03 UTC 
Created attachment 185356 [details] [review]
Fix the return type mismatch in gstrtsptransport.

The GstRTSPRange structure has both min and max with the type gint.In gstrtsptransport.c, the parse_range function is trying to parse the data with "strtol" which will return "long" . So it is better to check the return value with in G_MININT and G_MAXINT and remove the redundancy in code with split function .
Comment 1 Mark Nauwelaerts 2011-04-12 10:33:40 UTC 
Thanks.  Committed with some code style fixes.

commit fecd4a115405933a2c837ae0e10770c338adbbe6
Author: Sreerenj Balachandran <sreerenj.balachandran@nokia.com>
Date:   Wed Apr 6 22:57:41 2011 +0300

    rtsptranport: ensure valid int result when parsing ranges
    
    Specifically, make sure that the return value of strtol is falling in
    between the range of G_MININT and G_MAXINT.
    
    Fixes #646952.